docs(core): Correct the documented default interpolation strategy - #86
Open
bhj wants to merge 1 commit into
Open
docs(core): Correct the documented default interpolation strategy#86bhj wants to merge 1 commit into
bhj wants to merge 1 commit into
Conversation
SoundTouchOptions.interpolationStrategy carried `@defaultValue 'linear'`, but the default is `lanczos`: RateTransposer's constructor ends with `setInterpolationStrategy(interpolationStrategy ?? 'lanczos')`, and lanczos is the only strategy registered out of the box. The wrong value is worse than cosmetic here. `linear` ships in @soundtouchjs/interpolation-strategy-linear and has to be registered before use, so following the doc and passing `'linear'` throws "Unknown interpolation strategy id" from construction. The README already describes the registry correctly and shows the registerLinearStrategy opt-in, so this was the only place stating otherwise. Adds a spec pinning the default, which nothing covered — the existing strategy specs all pass an explicit id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model used: Anthropic Opus 5